linux-kernel - Re: [PATCH v13 04/23] x86/stacktool: Compile-time stack metadata validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56028FA1.1080801@suse.cz>
Date:	Wed, 23 Sep 2015 13:40:17 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Josh Poimboeuf <jpoimboe@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Cc:	linux-kernel@...r.kernel.org, live-patching@...r.kernel.org,
	Michal Marek <mmarek@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>,
	Andy Lutomirski <luto@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Pedro Alves <palves@...hat.com>,
	Namhyung Kim <namhyung@...il.com>,
	Bernd Petrovitsch <bernd@...rovitsch.priv.at>,
	Chris J Arges <chris.j.arges@...onical.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v13 04/23] x86/stacktool: Compile-time stack metadata
 validation

On 09/23/2015, 01:38 PM, Jiri Slaby wrote:
> On 09/22/2015, 05:46 PM, Josh Poimboeuf wrote:
> ...
>> --- /dev/null
>> +++ b/tools/stacktool/elf.c
>> @@ -0,0 +1,403 @@
> ...
>> +static struct section *find_section_by_index(struct elf *elf,
>> +					     unsigned int index)
>> +{
> ...
>> +}
>> +
>> +static struct symbol *find_symbol_by_index(struct elf *elf, unsigned int index)
>> +{
> 
> Hi, on openSUSE, I am getting:
> 
> elf.c:45: error: declaration of ‘index’ shadows a global declaration
> /usr/include/string.h:487: error: shadowed declaration is here
> elf.c: In function ‘find_symbol_by_index’:
> elf.c:56: error: declaration of ‘index’ shadows a global declaration
> /usr/include/string.h:487: error: shadowed declaration is here
> 
> which is index(3):
> extern char *index (__const char *__s, int __c)
>      __THROW __attribute_pure__ __nonnull ((1));
> 
> The same here:
> 
>> --- /dev/null
>> +++ b/tools/stacktool/special.c
>> @@ -0,0 +1,199 @@
> ...
>> +static int get_alt_entry(struct elf *elf, struct special_entry *entry,
>> +			 struct section *sec, int index,
>> +			 struct special_alt *alt)
>> +{
> ...
>> +int special_get_alts(struct elf *elf, struct list_head *alts)
>> +{

I erased too much here. Index is a local var here:
        int index, ret;

> 
> I fixed it obviously by s/index/idx/.
> 
> thanks,
-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/