linux-kernel - Re: [PATCH] hid-core: Avoid uninitialized buffer access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1509231409120.30132@pobox.suse.cz>
Date:	Wed, 23 Sep 2015 14:09:46 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Darren Hart <dvhart@...radead.org>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Richard Purdie <richard.purdie@...uxfoundation.org>,
	linux-input@...r.kernel.org, stable@...r.kernel.org,
	Darren Hart <dvhart@...ux.intel.com>
Subject: Re: [PATCH] hid-core: Avoid uninitialized buffer access

On Fri, 18 Sep 2015, Darren Hart wrote:

> From: Richard Purdie <richard.purdie@...uxfoundation.org>
> 
> hid_connect adds various strings to the buffer but they're all
> conditional. You can find circumstances where nothing would be written
> to it but the kernel will still print the supposedly empty buffer with
> printk. This leads to corruption on the console/in the logs.
> 
> Ensure buf is initialized to an empty string.
> 
> Signed-off-by: Richard Purdie <richard.purdie@...uxfoundation.org>
> [dvhart: Initialize string to "" rather than assign buf[0] = NULL;]
> Cc: Jiri Kosina <jikos@...nel.org>
> Cc: linux-input@...r.kernel.org
> Cc: stable@...r.kernel.org
> Signed-off-by: Darren Hart <dvhart@...ux.intel.com>
> ---
>  drivers/hid/hid-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 70a11ac..c0fbf4e 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -1611,7 +1611,7 @@ int hid_connect(struct hid_device *hdev, unsigned int connect_mask)
>  		"Multi-Axis Controller"
>  	};
>  	const char *type, *bus;
> -	char buf[64];
> +	char buf[64] = "";
>  	unsigned int i;
>  	int len;
>  	int ret;

Applied to hid.git#for-4.3/upstream-fixes.

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/