linux-kernel - Re: [PATCH] kexec: Add prefix "kexec" to output message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150923013723.GA4394@dhcp-129-160.nay.redhat.com>
Date:	Wed, 23 Sep 2015 09:37:24 +0800
From:	Dave Young <dyoung@...hat.com>
To:	Minfei Huang <mhuang@...hat.com>
Cc:	Minfei Huang <mnfhuang@...il.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	akpm@...ux-foundation.org, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kexec: Add prefix "kexec" to output message

On 09/23/15 at 12:07am, Minfei Huang wrote:
> On 09/15/15 at 11:08am, Minfei Huang wrote:
> > On 09/14/15 at 04:44pm, Dave Young wrote:
> > > On 09/14/15 at 03:50pm, Minfei Huang wrote:
> > > > On 09/13/15 at 11:52am, Eric W. Biederman wrote:
> > > > > Minfei Huang <mnfhuang@...il.com> writes:
> > > > > 
> > > > > > kexec output message misses the prefix "kexec", when Dave Young split
> > > > > > the kexec code. To keep the same format, add the prefix "kexec" to
> > > > > > output message.
> > > > > 
> > > > > What of kexec_core? What of the messages that already have a prefix?
> > > > > 
> > > > 
> > > > Hi, Eric.
> > > > 
> > > > Last commit(2965fa), Dave Young (dyoung@...hatcom) split the previous
> > > > kernel/kexec.c into three pieces(kexec_core.c, kexec_file.c, kexec.c).
> > > > The common functions used by both kexec and kexec_file are placed in
> > > > file kernel/kexec_core.c.
> > > > 
> > > > The format of the output message likes "kexec: SYSC_kexec_load: hello,
> > > > world" previously. Due to the missing prefix "kexec", now it like
> > > > "SYSC_kexec_load: hello, world".
> > > > 
> > > > Dave Young misses the Macro pr_fmt to define the prefix output message
> > > > in file kexec.c and kexec_file.c. I think the previous Macro was moved
> > > > into the file kexec_core.c when Dave did the splitting.
> > > 
> > > I'm not sure it is proper to add prefix "kexec: " in all kexec*.c, so
> > > only keep it in kexec_core.c.
> > > 
> > > There's already printks with prefix like "Kexec:", "crashkernel:" and
> > > other strings. Adding another prefix before them looks odd. So either remove 
> > > the prefix in kexec_core, or remove other prefixes already exists in kexec*.c
> > > I would prefix to remove the "kexec:" prefix in kexec_core.c
> > 
> > Hi, Dave.
> > 
> > How about removing all of the prefix "crashkernel" in kexec_core. Thus
> > we can be consistent with the output message prefix "kexec".
> 
> Ping, any comment is appreciate and helpful.

Remove "crashkernel" sounds not a proper way, it indicates crashkernel parsing
messages. I have no idea what is the best way but below modification sounds better to me:

kexec_core.c:

#define pr_fmt(fmt)        "[kexec_core] " fmt
Also remove below prefix "Kexec:"
pr_warn("Kexec: Memory allocation for saving cpu register states failed\n"); 

kexec.c:
#define pr_fmt(fmt)        "[kexec] " fmt

kexec_file.c:
#define pr_fmt(fmt)        "[kexec_file] " fmt

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/