linux-kernel - Re: [RFC v7 24/41] richacl: Set the other permissions to the other mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHpGcMJMgtqGDsxUYFXqVmenaLxdJHL3VO8byV0GtSkdrQMggw@mail.gmail.com>
Date:	Wed, 23 Sep 2015 16:12:42 +0200
From:	Andreas Grünbacher <andreas.gruenbacher@...il.com>
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	Andreas Gruenbacher <agruenba@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
	Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
	Linux API Mailing List <linux-api@...r.kernel.org>,
	linux-cifs@...r.kernel.org,
	LSM List <linux-security-module@...r.kernel.org>
Subject: Re: [RFC v7 24/41] richacl: Set the other permissions to the other mask

2015-09-23 16:03 GMT+02:00 J. Bruce Fields <bfields@...ldses.org>:
> On Sat, Sep 05, 2015 at 12:27:19PM +0200, Andreas Gruenbacher wrote:
>> +static int
>> +richacl_set_other_permissions(struct richacl_alloc *alloc)
>> +{
>> +     struct richacl *acl = alloc->acl;
>> +     unsigned int x = RICHACE_POSIX_ALWAYS_ALLOWED;
>> +     unsigned int other_mask = acl->a_other_mask & ~x;
>> +     struct richace *ace = acl->a_entries + acl->a_count - 1;
>> +
>> +     if (!(other_mask &&
>> +           (acl->a_flags & RICHACL_WRITE_THROUGH) &&
>> +           (acl->a_flags & RICHACL_MASKED)))
>> +             return 0;
>
> By the way, I think this is only called after checking MASKED--so the
> MASKED check here could be a WARN_ON, or could just be dropped.  Ditto
> for the following patch.

Hmm, yes. I'll drop that.

Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/