linux-kernel - Re: [PATCH v2] mfd: lpc_ich: Separate device cells for clarity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1629190950.19992.1443017599911.JavaMail.zimbra@xes-inc.com>
Date:	Wed, 23 Sep 2015 09:13:19 -0500 (CDT)
From:	Aaron Sierra <asierra@...-inc.com>
To:	Lee Jones <lee.jones@...aro.org>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Peter Tyser <ptyser@...-inc.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Jean Delvare <jdelvare@...e.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Matt Fleming <matt.fleming@...el.com>
Subject: Re: [PATCH v2] mfd: lpc_ich: Separate device cells for clarity

----- Original Message -----
> From: "Lee Jones" <lee.jones@...aro.org>
> Sent: Tuesday, September 22, 2015 7:31:19 PM
> 
> On Tue, 22 Sep 2015, Aaron Sierra wrote:
> 
> > The lpc_ich_cells array gives the wrong impression about the
> > relationship between the watchdog and GPIO devices. They are
> > completely distinct devices, so this patch separates the
> > array into distinct mfd_cell structs per device.
> > 
> > A side effect of removing the array, is that the lpc_cells enum
> > is no longer needed.
> > 
> > Signed-off-by: Aaron Sierra <asierra@...-inc.com>
> > ---
> >  v2 - rebase onto 4.3-rc2
> > 
> >  drivers/mfd/lpc_ich.c | 42 ++++++++++++++++++------------------------
> >  1 file changed, 18 insertions(+), 24 deletions(-)
> 
> Looks like you didn't apply Andy's Ack!

Sorry, Andy! I erred on the side of caution. I wasn't sure if
the Ack applied to the concept or the iteration of the patch.

> Applied with Andy's Ack.

Thanks

-Aaron
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/