linux-kernel - Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150923161519.15e0dd87@arm.com>
Date:	Wed, 23 Sep 2015 16:15:19 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Ley Foon Tan <lftan@...era.com>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	<linux-pci@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"Kumar Gala" <galak@...eaurora.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Subject: Re: [PATCH v7 3/6] pci:host: Add Altera PCIe host controller driver

On Wed, 23 Sep 2015 17:33:09 +0800
Ley Foon Tan <lftan@...era.com> wrote:

> On Wed, Sep 23, 2015 at 2:33 AM, Marc Zyngier <marc.zyngier@....com> wrote:
> > On Mon, 21 Sep 2015 10:13:04 +0800
> > Ley Foon Tan <lftan@...era.com> wrote:
> >
> >> This patch adds the Altera PCIe host controller driver.
> >>
> >> Signed-off-by: Ley Foon Tan <lftan@...era.com>
> >> ---
> >>  drivers/pci/host/Kconfig       |   8 +
> >>  drivers/pci/host/Makefile      |   1 +
> >>  drivers/pci/host/pcie-altera.c | 591 +++++++++++++++++++++++++++++++++++++++++
> >>  3 files changed, 600 insertions(+)
> >>  create mode 100644 drivers/pci/host/pcie-altera.c
> >>
> >> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> >> index d5e58ba..df9ed4f 100644
> >> --- a/drivers/pci/host/Kconfig
> >> +++ b/drivers/pci/host/Kconfig
> >> @@ -145,4 +145,12 @@ config PCIE_IPROC_BCMA
> >>         Say Y here if you want to use the Broadcom iProc PCIe controller
> >>         through the BCMA bus interface
> >>
> >> +config PCIE_ALTERA
> >> +     tristate "Altera PCIe controller"
> >> +     depends on ARCH_SOCFPGA || NIOS2
> >> +     select PCI_DOMAINS
> >> +     help
> >> +       Say Y here if you want to enable PCIe controller support for Altera
> >> +       SoCFPGA family of SoCs.
> >> +
> >
> > Is there anything in this driver that is actually specific to any of
> > these two platforms/architectures? I'd don't think we should restrict
> > if we can avoid it (hint: the companion MSI driver is not restricted to
> > any architecture).
> No specific dependency on these 2 architectures. Then I will remove this.

OK. If you fix this, you can put my

Reviewed-by: Marc Zyngier <marc.zyngier@....com>

on this patch.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/