linux-kernel - Re: [PATCH 2/2] ext4: implement cgroup writeback support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150923172535.GC25218@ret.masoncoding.com>
Date:	Wed, 23 Sep 2015 13:25:35 -0400
From:	Chris Mason <clm@...com>
To:	Artem Bityutskiy <dedekind1@...il.com>
CC:	"Theodore Ts'o" <tytso@....edu>, Tejun Heo <tj@...nel.org>,
	<axboe@...nel.dk>, <linux-kernel@...r.kernel.org>,
	<linux-fsdevel@...r.kernel.org>, <lizefan@...wei.com>,
	<cgroups@...r.kernel.org>, <hannes@...xchg.org>,
	<kernel-team@...com>, <adilger.kernel@...ger.ca>,
	<linux-ext4@...r.kernel.org>
Subject: Re: [PATCH 2/2] ext4: implement cgroup writeback support

On Wed, Sep 23, 2015 at 03:49:12PM +0300, Artem Bityutskiy wrote:
> On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote:
> > > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB.
> > > 
> > > Signed-off-by: Tejun Heo <tj@...nel.org>
> > > Cc: "Theodore Ts'o" <tytso@....edu>
> > > Cc: Andreas Dilger <adilger.kernel@...ger.ca>
> > > Cc: linux-ext4@...r.kernel.org
> > 
> > Thanks, applied.
> 
> Hi, this patch introduces a regression - a major one, I'd say.
> 
> Symptoms: copy a bunch of file, run sync, then run 'reboot', and after
> you boot up the copied files are corrupted. So basically the user
> -visible symptom is that 'sync' does not work.

Hi Artem,

Are you doing a hard shutdown (reboot -nf)?  If you're doing a friendly
shutdown, is the FS unmounting cleanly?

> 
> I quite an effort to bisect it, but it led me to this patch.

I bet it was a long bisect.  Trying to see if the same patch to btrfs
has similar impacts.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/