linux-kernel - Re: [PATCH v4 2/5] soc: sunxi: Add driver for Allwinner Reduced Serial Bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150923164532.GT30445@sirena.org.uk>
Date:	Wed, 23 Sep 2015 09:45:32 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Chen-Yu Tsai <wens@...e.org>
Cc:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Russell King <linux@....linux.org.uk>,
	linux-sunxi@...glegroups.com, Hans de Goede <hdegoede@...hat.com>,
	shuge@...winnertech.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/5] soc: sunxi: Add driver for Allwinner Reduced
 Serial Bus

On Thu, Sep 24, 2015 at 12:05:18AM +0800, Chen-Yu Tsai wrote:

> +static int sunxi_rsb_device_probe(struct device *dev)
> +{
> +	const struct sunxi_rsb_driver *drv = to_sunxi_rsb_driver(dev->driver);
> +	struct sunxi_rsb_device *rdev = to_sunxi_rsb_device(dev);
> +	int ret;
> +
> +	if (dev->bus != &sunxi_rsb_bus)
> +		return 0;

That's a bit worrying...  why might this get called for something other
than a rsb device?

> +struct regmap *devm_regmap_init_sunxi_rsb(struct sunxi_rsb_device *rdev,
> +					  const struct regmap_config *config);

This should work most of the time but you might want to take a look at
the changes introduced in 3cfe7a74d42b (regmap: Use different lockdep
class for each regmap init call) and follow a similar pattern for RSB to
avoid spurious lockdep warnings in some configurations - see the commit
log for that change for a full explanation.

Otherwise the regmap bit of this looks good, I'll try to have another
look through at the rest of the code later.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)