linux-kernel - Re: [PATCH] net/ibm/emac: bump version numbers for correct work with ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1443034983.12750.10.camel@decadent.org.uk>
Date:	Wed, 23 Sep 2015 20:03:03 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Miller <davem@...emloft.net>, ivan@...ibm.com
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	benh@...nel.crashing.org
Subject: Re: [PATCH] net/ibm/emac: bump version numbers for correct work
 with ethtool

On Wed, 2015-09-23 at 11:05 -0700, David Miller wrote:
> From: Ivan Mikhaylov <ivan@...ibm.com>
> Date: Wed, 23 Sep 2015 14:42:22 +0400
> 
> > Register dump out work preventing with 
> > old ethtool + new driver and new ethtool + old driver.
> 
> First of all you didn't provide a proper Signoff.
> 
> Second of all, there was so much discussion about whether this does
> or does not break things for various combinations of old/new ethtool
> and kernel.
> 
> Therefore I want a real detailed commit message that explains why this
> is all OK.  After so much confusion and discussion, providing a patch
> with absolutely no commit message is completely inappropriate.

I would suggest something like this:

"""
The size of the MAC register dump used to be the size specified by the
reg property in the device tree.  Userland has no good way of finding
out that size, and it was not specified consistently for each MAC type,
so ethtool would end up printing junk at the end of the register dump
if the device tree didn't match the size it assumed.

Using the new version numbers indicates unambiguously that the size of
the MAC register dump is dependent only on the MAC type.

Fixes: 5369c71f7ca2 ("net/ibm/emac: fix size of emac dump memory areas")
"""

Also:

Acked-by: Ben Hutchings <ben@...adent.org.uk>

Ben.

-- 
Ben Hutchings
Teamwork is essential - it allows you to blame someone else.
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)