linux-kernel - Re: [PATCH v2 0/9] Phy, mdiobus, and netdev struct device fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150923.162417.814596822188458346.davem@davemloft.net>
Date:	Wed, 23 Sep 2015 16:24:17 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linux@....linux.org.uk
Cc:	f.fainelli@...il.com, devicetree@...r.kernel.org,
	frowand.list@...il.com, grant.likely@...aro.org,
	isubramanian@....com, kchudgar@....com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, leoli@...escale.com,
	michal.simek@...inx.com, netdev@...r.kernel.org, rric@...nel.org,
	robh+dt@...nel.org, soren.brinkmann@...inx.com,
	sgoutham@...ium.com, thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH v2 0/9] Phy, mdiobus, and netdev struct device fixes

From: Russell King - ARM Linux <linux@....linux.org.uk>
Date: Tue, 22 Sep 2015 17:17:10 +0100

> This is the second version of the series, with the comments David had
> on the first patch fixed up.  Original series description with updated
> diffstat below.

This needs some build fixes:

drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function ‘xgene_enet_phy_connect’:
drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:694:20: error: too few arguments to function ‘of_phy_connect’
   pdata->phy_dev = of_phy_connect(ndev, phy_np,
                    ^
In file included from drivers/net/ethernet/apm/xgene/xgene_enet_main.h:31:0,
                 from drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:22:
include/linux/of_mdio.h:18:27: note: declared here
 extern struct phy_device *of_phy_connect(struct net_device *dev,
                           ^