linux-kernel - Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Sep 2015 13:41:56 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Luis de Bethencourt <luis@...ethencourt.com>,
	<linux-kernel@...r.kernel.org>
CC:	David Airlie <airlied@...ux.ie>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Grygorii Strashko <grygorii.strashko@...aro.org>,
	Rob Clark <robdclark@...il.com>,
	<dri-devel@...ts.freedesktop.org>
Subject: Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF
 platform driver


On 17/09/15 17:21, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 7841970..ecbc9e5 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -1014,6 +1014,7 @@ static const struct of_device_id dmm_of_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, dmm_of_match);
>  #endif
>  
>  struct platform_driver omap_dmm_driver = {

I think this one is not needed.

Tiler cannot be compiled as a module. Or, to be more exact, the tiler
driver is included in the omapdrm module, along with the main omapdrm
driver, which can be a module.

The autoloading should happen via omapdrm, and when that happens, tiler
driver comes along.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)