linux-kernel - Re: [PATCH 1/4] [resend #2] tridentfb: fix hang on Blade3D with CONFIG_CC_OPTIMIZE_FOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5603D94A.5060806@ti.com>
Date:	Thu, 24 Sep 2015 14:06:50 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Ondrej Zary <linux@...nbow-software.org>,
	Krzysztof Helt <krzysztof.h1@...pl>
CC:	<linux-fbdev@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] [resend #2] tridentfb: fix hang on Blade3D with
 CONFIG_CC_OPTIMIZE_FOR_SIZE



On 24/08/15 22:37, Ondrej Zary wrote:
> When the kernel is compiled with -Os (CONFIG_CC_OPTIMIZE_FOR_SIZE), tridentfb
> hangs the machine upon load with Blade3D cards unless acceleration is disabled.
> 
> This is caused by memcpy() which copies data byte-by-byte (rep movsb) when
> compiled with -Os. The card does not like that - it requires 32-bit access.
> 
> Use iowrite_32() instead.
> 
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>
> Acked-by: Krzysztof Helt <krzysztof.h1@...pl>
> ---
>  drivers/video/fbdev/tridentfb.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
> index 7ed9a22..7429713 100644
> --- a/drivers/video/fbdev/tridentfb.c
> +++ b/drivers/video/fbdev/tridentfb.c
> @@ -226,7 +226,7 @@ static void blade_image_blit(struct tridentfb_par *par, const char *data,
>  	writemmr(par, DST1, point(x, y));
>  	writemmr(par, DST2, point(x + w - 1, y + h - 1));
>  
> -	memcpy(par->io_virt + 0x10000, data, 4 * size);
> +	iowrite32_rep(par->io_virt + 0x10000, data, size);
>  }
>  
>  static void blade_copy_rect(struct tridentfb_par *par,
> 

Thanks, queued for 4.3 fixes.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)