linux-kernel - Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5603E567.5000001@ti.com>
Date:	Thu, 24 Sep 2015 14:58:31 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Jonathan Corbet <corbet@....net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-kernel@...r.kernel.org>, <linux-fbdev@...r.kernel.org>,
	<linux-doc@...r.kernel.org>, <devel@...verdev.osuosl.org>
Subject: Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

On 02/09/15 15:48, Sudip Mukherjee wrote:

> Now I am getting confused. :(
> Since this has already been merged I guess we need to maintain it now.

Oh, ok. I thought it was still in staging. I haven't been able to follow
the list properly lately...

Well, in theory we could still revert it, as it's only -rc2.

> So then should I fix the things you pointed out or should i instead
> give more priority to the DRM driver and fix these things later?

Is there a public datasheet for the HW?

The driver as it is now is quite horrible. Huge tables of raw data,
written directly to the registers. Lots of magic numbers all around.
Even with a datasheet, presuming it's public and it contains all those
values, the driver is rather unmaintainable.

All those need to be sorted out for the DRM driver anyway, so maybe it's
better to clean up the fb driver first.

> And, just to inform you, there are two more fbdev drivers in staging,
> staging/sm750fb and staging/fbtft. And the ultimate goal of any driver

Thanks for pointing this out, I need to check those and think how to
proceed.

 Tomi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)