linux-kernel - Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56041A25.60400@ti.com>
Date:	Thu, 24 Sep 2015 18:43:33 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Luis de Bethencourt <luis@...ethencourt.com>
CC:	<linux-kernel@...r.kernel.org>, David Airlie <airlied@...ux.ie>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Grygorii Strashko <grygorii.strashko@...aro.org>,
	Rob Clark <robdclark@...il.com>,
	<dri-devel@...ts.freedesktop.org>,
	Javier Martinez Canillas <javier@....samsung.com>
Subject: Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF
 platform driver


On 24/09/15 18:36, Luis de Bethencourt wrote:

> I am a bit confused.

Yes, it's an interesting mess due to legacy reasons. Maybe we manage to
fix it some day...

> So how the OMAP DRM auto loading is supposed to work when using Device Trees?

omapdrm isn't a real HW device driver at the moment. There's another
driver, omapdss, which is the HW driver, and omapdrm uses omapdss.
omapdrm platform device is created by omap platform code at boot time,
the same way for both DT and non-DT boots.

> As far as I can tell, the main omap drm driver does not have a OF device ID
> table and a .of_match it only has a MODULE_ALIAS("platform:" DRIVER_NAME),
> but the tiler driver (that is built-in the omap drm driver) does have a a
> OF device ID table and I see in DTS that are device nodes using those compatible
> strings
> 
> $ git grep omap4-dmm arch/arm/boot/dts/omap*
> arch/arm/boot/dts/omap4.dtsi:                   compatible = "ti,omap4-dmm";
> 
> Does that mean there is no need for MODULE_ALIAS("platform:" DMM_DRIVER_NAME)?

No, I think that's the thing that makes omapdrm load.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)