linux-kernel - Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix for block comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Sep 2015 22:27:55 +0530
From:	punit vara <punitvara@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	devel@...verdev.osuosl.org,
	Flo Schil <florian.c.schilhabel@...glemail.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, Larry.Finger@...inger.net
Subject: Re: [PATCH] Staging: rtl8712: rtl871x_mp.h: Coding style warnings fix
 for block comment

On Thu, Sep 24, 2015 at 4:52 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> On Thu, Sep 24, 2015 at 03:57:22PM +0530, Sudip Mukherjee wrote:
>> On Thu, Sep 24, 2015 at 12:00:01PM +0300, Dan Carpenter wrote:
>> > On Thu, Sep 24, 2015 at 01:54:22AM +0530, Punit Vara wrote:
>> > > This is a patch to the rtl871x_mp.h that fixes up following warnings
>> > > reported by checkpatch.pl :
>> > >
>> > > -Block comments use a trailing */ on a separate line
>> > >
>> > > Signed-off-by: Punit Vara <punitvara@...il.com>
>> > > ---
>> > >  drivers/staging/rtl8712/rtl871x_mp.h | 3 ++-
>> > >  1 file changed, 2 insertions(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/staging/rtl8712/rtl871x_mp.h b/drivers/staging/rtl8712/rtl871x_mp.h
>> > > index 75893f2..20a4273 100644
>> > > --- a/drivers/staging/rtl8712/rtl871x_mp.h
>> > > +++ b/drivers/staging/rtl8712/rtl871x_mp.h
>> > > @@ -108,7 +108,8 @@ struct mp_priv {
>> > >   unsigned char network_macaddr[6];
>> > >   /*Testing Flag*/
>> > >   u32 mode;/*0 for normal type packet,
>> >
>> > This first line is missing some spaces so the whole comment needs to be
>> > redone.
>> >
>> >     u32 mode; /* 0 for normal type packet,
>> >                * 1 for loopback packet (16bytes TXCMD)
>> >                */
>> If he is modifying the first line then shouldn't it be:
>>       u32 mode; /*
>>                  * 0 for normal type packet,
>>                  * 1 for loopback packet (16bytes TXCMD)
>>                  */
>>
>
> Networking code doesn't use the empty first line.
>
> regards,
> dan carpenter
>



Yes I did that mistake in 2-3 files but after that I have got I was
doing mistake . Then I did not repeat the mistake. I Am waiting for
Greg's response whether again I have to send all patches in series So
I will definitely resend after fixing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/