linux-kernel - Re: + zsmalloc-add-comments-for-inuse-to-zspage.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20150924034919.GA626@swordfish>
Date:	Thu, 24 Sep 2015 12:49:19 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	akpm@...ux-foundation.org
Cc:	zhuhui@...omi.com, ddstreet@...e.org, minchan@...nel.org,
	sergey.senozhatsky@...il.com, mm-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: + zsmalloc-add-comments-for-inuse-to-zspage.patch added to -mm
 tree

On (09/23/15 14:53), akpm@...ux-foundation.org wrote:
> ------------------------------------------------------
> From: Hui Zhu <zhuhui@...omi.com>
> Subject: zsmalloc: add comments for ->inuse to zspage
> 
> Signed-off-by: Hui Zhu <zhuhui@...omi.com>
> Cc: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Cc: Dan Streetman <ddstreet@...e.org>
> Cc: Minchan Kim <minchan@...nel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  mm/zsmalloc.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -puN mm/zsmalloc.c~zsmalloc-add-comments-for-inuse-to-zspage mm/zsmalloc.c
> --- a/mm/zsmalloc.c~zsmalloc-add-comments-for-inuse-to-zspage
> +++ a/mm/zsmalloc.c
> @@ -38,6 +38,7 @@
>   *	page->lru: links together first pages of various zspages.
>   *		Basically forming list of zspages in a fullness group.
>   *	page->mapping: class index and fullness group of the zspage
> + *	page->inuse: the pages number that is used in this zspage

Probably arrived last night to my another mailbox, so haven't
seen this one.


The comment is wrong. page ->inuse represents the number of objects
in use in this zspage; not "the pages number".

usage example:

zspage_full() : page->inuse == page->objects
obj_malloc() : first_page->inuse++
obj_free() : first_page->inuse--

	-ss
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/