linux-kernel - Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150925090114.GA19496@shlinux2>
Date:	Fri, 25 Sep 2015 17:01:16 +0800
From:	Peter Chen <peter.chen@...escale.com>
To:	Felipe Tonello <eu@...ipetonello.com>
CC:	USB list <linux-usb@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Felipe Balbi <balbi@...com>,
	"Andrzej Pietrasiewicz" <andrzej.p@...sung.com>
Subject: Re: [PATCH v2 1/3] usb: chipidea: core: fix when building without
 CONFIG_PM support

On Fri, Sep 25, 2015 at 09:26:21AM +0100, Felipe Tonello wrote:
> Hi Peter,
> 
> On Thu, Sep 24, 2015 at 2:17 AM, Peter Chen <peter.chen@...escale.com> wrote:
> > On Wed, Sep 23, 2015 at 12:56:58PM +0100, Felipe F. Tonello wrote:
> >> If CONFIG_PM or CONFIG_PM_SLEEP is not set, driver will not compile
> >> properly.
> >>
> >
> > Would you post the warning or error messages?
> >
> > I just tried at v4.3-rc1 (v4.2 should be same), without any problems.
> 
> Actually I tested again with the latest and it doesn't break. But
> still I believe it is the right thing to do, even though it builds.
> Just good practice to make sure the ifdefs are correct on driver code.
> 

We need to decrease #ifdefs as less as possible, only add it if it
really needs.

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/