| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1443145038-30699-1-git-send-email-bjorn.andersson@sonymobile.com> Date: Thu, 24 Sep 2015 18:37:18 -0700 From: Bjorn Andersson <bjorn.andersson@...ymobile.com> To: Andy Gross <agross@...eaurora.org> CC: Courtney Cavin <courtney.cavin@...ymobile.com>, <linux-arm-msm@...r.kernel.org>, <linux-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: [PATCH] soc: qcom: smd: Reject send of too big packets Attempting to find room for a packet that's bigger than the fifo will never succeed and the calling process will be sleeping forever in the loop, waiting for enough room. So fail early instead. Reported-by: Courtney Cavin <courtney.cavin@...ymobile.com> Signed-off-by: Bjorn Andersson <bjorn.andersson@...ymobile.com> --- drivers/soc/qcom/smd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/soc/qcom/smd.c b/drivers/soc/qcom/smd.c index 18964f154383..88353bda1ea4 100644 --- a/drivers/soc/qcom/smd.c +++ b/drivers/soc/qcom/smd.c @@ -723,6 +723,10 @@ int qcom_smd_send(struct qcom_smd_channel *channel, const void *data, int len) if (channel->info_word && len % 4) return -EINVAL; + /* Reject packets that are too big */ + if (tlen >= channel->fifo_size) + return -EINVAL; + ret = mutex_lock_interruptible(&channel->tx_lock); if (ret) return ret; -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists