linux-kernel - Re: [PATCH] fs, seqfile: always allow oom killer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1443186815.29850.182.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 25 Sep 2015 06:13:35 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Greg Thelen <gthelen@...gle.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	David Rientjes <rientjes@...gle.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs, seqfile: always allow oom killer

On Fri, 2015-09-25 at 00:43 -0700, Greg Thelen wrote:
> Since commit 5cec38ac866b ("fs, seq_file: fallback to vmalloc instead of
> oom kill processes") seq_buf_alloc() avoids calling the oom killer for
> PAGE_SIZE or smaller allocations; but larger allocations can use the oom
> killer via vmalloc().  Thus reads of small files can return ENOMEM, but
> larger files use the oom killer to avoid ENOMEM.
> 
> Memory overcommit requires use of the oom killer to select a victim
> regardless of file size.
> 
> Enable oom killer for small seq_buf_alloc() allocations.
> 
> Signed-off-by: David Rientjes <rientjes@...gle.com>
> Signed-off-by: Greg Thelen <gthelen@...gle.com>
> ---

Acked-by: Eric Dumazet <edumazet@...gle.com>

Thanks guys.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/