linux-kernel - Re: [PATCH 3/6] drm/imx: Build monolithic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150925142133.GA22463@ulmo>
Date:	Fri, 25 Sep 2015 16:21:33 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>
Cc:	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/6] drm/imx: Build monolithic driver

On Fri, Sep 25, 2015 at 03:13:54PM +0200, Philipp Zabel wrote:
> Am Freitag, den 25.09.2015, 15:09 +0200 schrieb Philipp Zabel:
> > Am Freitag, den 25.09.2015, 14:17 +0200 schrieb Thierry Reding:
> > > I think you gain much less by splitting up than you realize. Compare
> > > this from before the series:
> > > 
> > > 	$ du -ch drivers/gpu/drm/imx/*.ko
> > > 	8.0K    drivers/gpu/drm/imx/dw_hdmi-imx.ko
> > 
> > Oh right, I didn't realize that this is just the shim. The bulk of the
> > HDMI driver is in bridge/dw_hdmi.ko.
> > 
> > > 	16K     drivers/gpu/drm/imx/imxdrm.ko
> > > 	16K     drivers/gpu/drm/imx/imx-ipuv3-crtc.ko
> > > 	12K     drivers/gpu/drm/imx/imx-ldb.ko
> > > 	12K     drivers/gpu/drm/imx/imx-tve.ko
> > > 	8.0K    drivers/gpu/drm/imx/parallel-display.ko
> > > 	72K     total
> > [...]
> > > with this after the series:
> > > 
> > > 	$ du -ch drivers/gpu/drm/imx/*.ko
> > > 	44K     drivers/gpu/drm/imx/imx-drm.ko
> > > 	44K     total
> > [...]
> > > There are other things to consider as well, such as the additional
> > > memory overhead caused by merely having multiple modules, or all of the
> > > exported functions that unnecessarily clutter up the symbol table, and
> > > which end up slowing down every symbol lookup.
> > 
> > Thanks, can't argue with those numbers.
> > I'll queue patches 3 and 4 for imx-drm.
> 
> Wait, I won't because they depend on the helper function in patch 1.
> 
> Acked-by: Philipp Zabel <p.zabel@...gutronix.de>
> 
> then. Can I get a stable tag so I can solve potential merge conflicts in
> imx-drm-core.c?

Let's see what Greg thinks about patch 1. There are a bunch of other
drivers that can use these helpers, so it might be best to get the
helper merged first and hold off on the depending patches until the
next release.

I'll let you know when we've figured out how to merge this.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)