linux-kernel - Re: [PATCH] ASoC: sgtl5000: fix bad register MIC_BIAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150925165028.GJ30445@sirena.org.uk>
Date:	Fri, 25 Sep 2015 09:50:28 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Gianluca Renzi <gianlucarenzi@...ekelettronica.it>
Cc:	Liam Girdwood <lgirdwood@...il.com>, Takashi Iwai <tiwai@...e.com>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: sgtl5000: fix bad register MIC_BIAS_VOLTAGE setup
 on probe

On Fri, Sep 25, 2015 at 04:21:27PM +0200, Gianluca Renzi wrote:

>  	snd_soc_update_bits(codec, SGTL5000_CHIP_MIC_CTRL,
>  			SGTL5000_BIAS_R_MASK,
> -			sgtl5000->micbias_voltage << SGTL5000_BIAS_R_SHIFT);
> +			sgtl5000->micbias_voltage << SGTL5000_BIAS_VOLT_SHIFT);

That doesn't look right...  I would expect _BIAS_R_SHIFT to shift a
value into the register masked off by _BIAS_R_MASK and therefore that
the above is saying that the definition of one of those two macros is
wrong.  I would not expect something called _BIAS_VOLT_SHIFT here.

What's going on here?

> @@ -1549,7 +1549,7 @@ static int sgtl5000_i2c_probe(struct i2c
>  			else {
>  				sgtl5000->micbias_voltage = 0;
>  				dev_err(&client->dev,
> -					"Unsuitable MicBias resistor\n");
> +					"Unsuitable MicBias voltage\n");
>  			}

This looks like a reasonable but unrelated fix and should be in a
separate patch.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)