linux-kernel - Re: [PATCH] gpio/pca953x: Add TI TCA9539 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYvdW=g41z+Y74gtcuuwvGEC98tUUoHKuVh5=28R2ZD5g@mail.gmail.com>
Date:	Fri, 25 Sep 2015 10:17:24 -0700
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio/pca953x: Add TI TCA9539 support

On Wed, Sep 9, 2015 at 8:23 AM, Thierry Reding <thierry.reding@...il.com> wrote:

> From: Thierry Reding <treding@...dia.com>
>
> The TCA9539 is almost identical to the PCA9555 and software-compatible
> with this driver. It exposes 16 general purpose I/O pins in two 8-bit
> configurations.
>
> Signed-off-by: Thierry Reding <treding@...dia.com>

Looks good! But:

> +       { .compatible = "ti,tca9539", },

You forgot to patch Documentation/devicetree/bindings/gpio/gpio-pca953x.txt

Fix that and I'll apply it.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/