linux-kernel - Re: [PATCH V2] kexec: Use file name as the output message prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150925050444.GA11707@dhcp-129-149.nay.redhat.com>
Date:	Fri, 25 Sep 2015 13:04:44 +0800
From:	Dave Young <dyoung@...hat.com>
To:	Minfei Huang <mnfhuang@...il.com>
Cc:	ebiederm@...ssion.com, akpm@...ux-foundation.org, bhe@...hat.com,
	kexec@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] kexec: Use file name as the output message prefix

On 09/24/15 at 02:07pm, Minfei Huang wrote:
> kexec output message misses the prefix "kexec", when Dave Young split
> the kexec code. Now, we use file name as the output message prefix.
> 
> Currectly, the format of output message:
> [  140.290795] SYSC_kexec_load: hello, world
> [  140.291534] kexec: sanity_check_segment_list: hello, world
> 
> Ideally, the format of output message:
> [   30.791503] kexec: SYSC_kexec_load, Hello, world
> [   79.182752] kexec_core: sanity_check_segment_list, Hello, world
> 
> Remove the custom prefix "kexec" in output message.
> 
> Signed-off-by: Minfei Huang <mnfhuang@...il.com>
> ---
> v2: Use KBUILD_MODNAME as prefix, instead of custom string "kexec"
> ---
>  kernel/kexec.c      | 2 ++
>  kernel/kexec_core.c | 4 ++--
>  kernel/kexec_file.c | 2 ++
>  3 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 4c5edc3..df772fc 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -18,6 +18,8 @@
>  
>  #include "kexec_internal.h"
>  
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +

Move the micro to the top of the c file is better, ditto for other two files.

Otherwise:
Acked-by: Dave Young <dyoung@...hat.com>

>  static int copy_user_segment_list(struct kimage *image,
>  				  unsigned long nr_segments,
>  				  struct kexec_segment __user *segments)
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index 201b453..dd21c78 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -6,7 +6,7 @@
>   * Version 2.  See the file COPYING for more details.
>   */
>  
> -#define pr_fmt(fmt)	"kexec: " fmt
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>  
>  #include <linux/capability.h>
>  #include <linux/mm.h>
> @@ -1027,7 +1027,7 @@ static int __init crash_notes_memory_init(void)
>  
>  	crash_notes = __alloc_percpu(size, align);
>  	if (!crash_notes) {
> -		pr_warn("Kexec: Memory allocation for saving cpu register states failed\n");
> +		pr_warn("Memory allocation for saving cpu register states failed\n");
>  		return -ENOMEM;
>  	}
>  	return 0;
> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
> index 6a9a3f2..66a5dc8 100644
> --- a/kernel/kexec_file.c
> +++ b/kernel/kexec_file.c
> @@ -22,6 +22,8 @@
>  #include <linux/vmalloc.h>
>  #include "kexec_internal.h"
>  
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
>  /*
>   * Declare these symbols weak so that if architecture provides a purgatory,
>   * these will be overridden.
> -- 
> 1.9.1
> 

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/