linux-kernel - Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to right side of the comparision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5606D9CA.1040502@lwfinger.net>
Date:	Sat, 26 Sep 2015 12:45:46 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Punit Vara <punitvara@...il.com>
Cc:	florian.c.schilhabel@...glemail.com, gregkh@...uxfoundation.org,
	sudipm.mukherjee@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, dogukan.ergun@...il.com,
	stillcompiling@...il.com, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] Staging: rtl8712: rtl871x_ioctl_linux.c Move constant to
 right side of the comparision

On 09/26/2015 11:49 AM, Punit Vara wrote:
> This patch is to the rtl871x_ioctl_linux.c that fixes up following
> warning reported by checkpatch.pl :
>
> - Comparisons should place the constant on the right side of the test
>
> Signed-off-by: Punit Vara <punitvara@...il.com>

This warning is crap. WTF difference does it make???? The compiler does not 
care, and any reader with any piece of a brain is not going to be confused!

This patch and all others like it are just meaningless source churning!

This author has made such a royal mess of his patches that I recommend that ALL 
of them be dropped. In addition, we should continue to drop his changes until he 
learns how to use git to generate N/M patches, and until he reads the 
documentation on patch submission.

Larry

> ---
>   drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index 143be0f..6d7f8f7 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -957,7 +957,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
>   	if (IS_ERR(ext))
>   		return PTR_ERR(ext);
>
> -	if (0 == strcasecmp(ext, "RSSI")) {
> +	if (strcasecmp(ext, "RSSI") == 0) {
>   		/*Return received signal strength indicator in -db for */
>   		/* current AP */
>   		/*<ssid> Rssi xx */
> @@ -974,7 +974,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
>   		} else {
>   			sprintf(ext, "OK");
>   		}
> -	} else if (0 == strcasecmp(ext, "LINKSPEED")) {
> +	} else if (strcasecmp(ext, "LINKSPEED") == 0) {
>   		/*Return link speed in MBPS */
>   		/*LinkSpeed xx */
>   		union iwreq_data wrqd;
> @@ -982,30 +982,30 @@ static int r871x_wx_set_priv(struct net_device *dev,
>   		int mbps;
>
>   		ret_inner = r8711_wx_get_rate(dev, info, &wrqd, extra);
> -		if (0 != ret_inner)
> +		if (ret_inner != 0)
>   			mbps = 0;
>   		else
>   			mbps = wrqd.bitrate.value / 1000000;
>   		sprintf(ext, "LINKSPEED %d", mbps);
> -	} else if (0 == strcasecmp(ext, "MACADDR")) {
> +	} else if (strcasecmp(ext, "MACADDR") == 0) {
>   		/*Return mac address of the station */
>   		/* Macaddr = xx:xx:xx:xx:xx:xx */
>   		sprintf(ext, "MACADDR = %pM", dev->dev_addr);
> -	} else if (0 == strcasecmp(ext, "SCAN-ACTIVE")) {
> +	} else if (strcasecmp(ext, "SCAN-ACTIVE") == 0) {
>   		/*Set scan type to active */
>   		/*OK if successful */
>   		struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>
>   		pmlmepriv->passive_mode = 1;
>   		sprintf(ext, "OK");
> -	} else if (0 == strcasecmp(ext, "SCAN-PASSIVE")) {
> +	} else if (strcasecmp(ext, "SCAN-PASSIVE") == 0) {
>   		/*Set scan type to passive */
>   		/*OK if successful */
>   		struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
>
>   		pmlmepriv->passive_mode = 0;
>   		sprintf(ext, "OK");
> -	} else if (0 == strncmp(ext, "DCE-E", 5)) {
> +	} else if (strncmp(ext, "DCE-E", 5) == 0) {
>   		/*Set scan type to passive */
>   		/*OK if successful */
>   		r8712_disconnectCtrlEx_cmd(padapter
> @@ -1015,7 +1015,7 @@ static int r871x_wx_set_priv(struct net_device *dev,
>   			, 5000 /*u32 firstStageTO */
>   		);
>   		sprintf(ext, "OK");
> -	} else if (0 == strncmp(ext, "DCE-D", 5)) {
> +	} else if (strncmp(ext, "DCE-D", 5) == 0) {
>   		/*Set scan type to passive */
>   		/*OK if successfu */
>   		r8712_disconnectCtrlEx_cmd(padapter
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/