[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150927202715.GE24007@krava.redhat.com>
Date: Sun, 27 Sep 2015 22:27:15 +0200
From: Jiri Olsa <jolsa@...hat.com>
To: He Kuang <hekuang@...wei.com>
Cc: a.p.zijlstra@...llo.nl, mingo@...hat.com, acme@...nel.org,
jolsa@...nel.org, kan.liang@...el.com, adrian.hunter@...el.com,
wangnan0@...wei.com, pi3orama@....com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] perf tools: Prompt error message for wrong terms
of hw/sw events
On Fri, Sep 25, 2015 at 11:11:49AM +0000, He Kuang wrote:
> Prompt proper error message when wrong config terms is specificed for
> hw/sw type perf events. This patch makes the original error prompt
> function formats_error_string() more generic, which only outputs the
> static config terms for hw/sw perf events, and prepends pmu formats
> for pmu events.
>
> Before this patch:
>
> $ perf record -e 'cpu-clock/freq=200/' -a sleep 1
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.028 MB perf.data (202 samples) ]
>
> $ perf record -e 'cpu-clock/freqx=200/' -a sleep 1
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 0.042 MB perf.data (506 samples) ]
this output is not correct at this version,
patch 1/4 will make the above command fail
please change the example accordingly
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists