linux-kernel - Re: [PATCH] x86/mm: Export cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150927112853.GA8329@pd.tnic>
Date:	Sun, 27 Sep 2015 13:28:54 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Andy Lutomirski <luto@...capital.net>,
	James Forcier <csssuf@...suf.net>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Ingo Molnar <mingo@...hat.com>,
	Jan Beulich <JBeulich@...e.com>, X86 ML <x86@...nel.org>,
	"Juergen Gross <jgross@...e.com, Toshi Kani" <toshi.kani@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] x86/mm: Export cpu_tlbstate as non-GPL symbol

On Sun, Sep 27, 2015 at 12:46:28PM +0200, Thomas Gleixner wrote:
> > https://github.com/kolasa/fglrx-13.152/blob/master/firegl_public.c
> 
> I stopped looking at this line:
> 
> MODULE_LICENSE("GPL\0Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");

"GPL" *and* "Proprietary"??!

How does that even work?

Oh, that depends on the kernel version:

#if LINUX_VERSION_CODE < KERNEL_VERSION(3,19,0)
MODULE_LICENSE("Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");
#else
MODULE_LICENSE("GPL\0Proprietary. (C) 2002 - ATI Technologies, Starnberg, GERMANY");
#endif

With that '\0' string terminator in there?! WTF now?!

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/