linux-kernel - RE: [PATCH 1/1] dmaengine: dw: resolve recursion lock when audio playback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <037301d0f9ce$1908ca10$4b1a5e30$@tangramtek.com>
Date:	Mon, 28 Sep 2015 17:14:36 +0800
From:	"yitian" <yitian.bu@...gramtek.com>
To:	"'Andy Shevchenko'" <andriy.shevchenko@...ux.intel.com>,
	"'Andy Shevchenko'" <andy.shevchenko@...il.com>,
	"'Viresh Kumar'" <viresh.kumar@...aro.org>
Cc:	"'Viresh Kumar'" <vireshk@...nel.org>,
	"'Vinod Koul'" <vinod.koul@...el.com>,
	"'Dan Williams'" <dan.j.williams@...el.com>,
	"'dmaengine'" <dmaengine@...r.kernel.org>,
	"'Linux Kernel Mailing List'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/1] dmaengine: dw: resolve recursion lock when audio playback

> From: Andy Shevchenko [mailto:andriy.shevchenko@...ux.intel.com]
> Sent: Monday, September 28, 2015 4:46 PM
> To: yitian <yitian.bu@...gramtek.com>; 'Andy Shevchenko'
> <andy.shevchenko@...il.com>; 'Viresh Kumar' <viresh.kumar@...aro.org>
> Cc: 'Viresh Kumar' <vireshk@...nel.org>; 'Vinod Koul'
> <vinod.koul@...el.com>; 'Dan Williams' <dan.j.williams@...el.com>;
> 'dmaengine' <dmaengine@...r.kernel.org>; 'Linux Kernel Mailing List'
> <linux-kernel@...r.kernel.org>
> Subject: Re: [PATCH 1/1] dmaengine: dw: resolve recursion lock when
> audio playback
> 
> On Mon, 2015-09-28 at 15:23 +0800, yitian wrote:
> > >
> > > From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> > > Sent: Monday, September 28, 2015 3:06 PM
> > > To: Viresh Kumar <viresh.kumar@...aro.org>
> > > Cc: yitian <yitian.bu@...gramtek.com>; Viresh Kumar
> > > <vireshk@...nel.org>; Andy Shevchenko
> > > <andriy.shevchenko@...ux.intel.com>; Vinod Koul <
> > > vinod.koul@...el.com>;
> > > Dan Williams <dan.j.williams@...el.com>; dmaengine
> > > <dmaengine@...r.kernel.org>; Linux Kernel Mailing List
> > > <linux-kernel@...r.kernel.org>
> > > Subject: Re: [PATCH 1/1] dmaengine: dw: resolve recursion
> > > > I am not sure if this is a sane way of doing that, and we were
> > > > scanning
> > > > the descriptors for some valid reason..
> > >
> > > Actually one of the patches in a pile sitting in my private repo is
> > > also including similar change. In my case the reason is to support
> > > cyclic transfers natively.
> > >
> >
> > Yes, i am using DW DMAC to support cyclic transfer.
> > Currently it is very easy to get recursion lock crash, but
> > after this patch everything is fine on my device.
> 
> What is an actual hardware you are running kernel on?
> 
Hi Andy:

I am using a FPGA, with Cortex-A5 core, Designware I2S IP, Designware
DMAC IP. What I was done is to run tinyplay and tinycap to test the
playback and capture function on the FPGA. With my change, both of
them are okay now. I didn't push the patch which added cyclic DMA
support for dw DMAC because I didn't make it decent enough yet.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/