linux-kernel - Re: [PATCH 3/9] drivers:mtd:ubi:add metadata struct for UBI bakvol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150928120651.5c55317d@bbrezillon>
Date:	Mon, 28 Sep 2015 12:06:51 +0200
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	"Bean Huo 霍斌斌 (beanhuo)" <beanhuo@...ron.com>
Cc:	"dedekind1@...il.com" <dedekind1@...il.com>,
	"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
	"computersforpeace@...il.com" <computersforpeace@...il.com>,
	"baruch@...s.co.il" <baruch@...s.co.il>,
	"asierra@...-inc.com" <asierra@...-inc.com>,
	"guz.fnst@...fujitsu.com" <guz.fnst@...fujitsu.com>,
	"gsi@...x.de" <gsi@...x.de>, "richard@....at" <richard@....at>,
	David Woodhouse <dwmw2@...radead.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	"Frank Liu 刘群 (frankliu)" <frankliu@...ron.com>,
	Andrea Scian <rnd4@...e-tech.it>,
	"Peter Pan 潘柏宏 (peterpan)" <peterpan@...ron.com>,
	"Karl Zhang 张双锣 (karlzhang)" 
	<karlzhang@...ron.com>,
	Iwo Mergler <Iwo.Mergler@...commwireless.com>,
	"Jeff Lauruhn (jlauruhn)" <jlauruhn@...ron.com>,
	Stefan Roese <sr@...x.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/9] drivers:mtd:ubi:add metadata struct for UBI bakvol

On Mon, 28 Sep 2015 07:02:42 +0000
Bean Huo 霍斌斌 (beanhuo) <beanhuo@...ron.com> wrote:

> Add metadata struct for UBI bakvol.
> Currently , bakvol reserves 20 PEBs for internal log volume.
> Shares wear-leveling operation with ubi. 
> 
> 
> Signed-off-by: Bean Huo <beanhuo@...ron.com>
> ---
>  drivers/mtd/ubi/ubi-media.h | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 

[...]

>  
> @@ -325,6 +339,32 @@ struct ubi_vid_hdr {
>  #define UBI_VTBL_RECORD_SIZE_CRC (UBI_VTBL_RECORD_SIZE - sizeof(__be32))
>  
>  /**
> + * struct ubi_bkblk_info - the information for one backup block .
> + * @pbn: physical block number
> + * @lbn:  logic block number
> + * @plane: this block belongs to which plane
> + * @pgnum: the page number (lower page) that can be programmed last time
> + */

I'm not sure to understand what those fields are used for, but I guess
I'll understand it while reviewing the following patches.

> +struct ubi_bkblk_info {
> +	__be32  pbn;
> +	__be32  lbn;
> +	__u8    plane;
> +	__be32  pgnum;
> +	struct  list_head node;
> +};

You're mixing runtime and storage representation: node has nothing to
do here.

> +
> +/**
> + * struct ubi_bkblk_tbl - a table for backup blocks.
> + * @volume_built: indicate if backup volume be initted
> + * @bcount_of_plane:  block count that has bee applied for corresponding plane
> + */
> +struct ubi_bkblk_tbl {
> +	__u8    volume_built;
> +	__be32  bcount_of_plane[2];
> +	struct  list_head head;
> +};

Ditto.



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/