linux-kernel - Re: Re: [PATCH] dax: fix deadlock in __dax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Sep 2015 18:23:52 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Dave Chinner <david@...morbit.com>
Cc:	kbuild-all@...org, Ross Zwisler <ross.zwisler@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Matthew Wilcox <willy@...ux.intel.com>,
	linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dan Williams <dan.j.williams@...el.com>,
	"Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
	linux-nvdimm@...ts.01.org, Jan Kara <jack@...e.cz>
Subject: Re: Re: [PATCH] dax: fix deadlock in __dax_fault

Hi Dave,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: mips-allyesconfig (attached as .config)
reproduce:
  wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
  chmod +x ~/bin/make.cross
  git checkout 285753fa883fcbeac6b393da338b6e976af57912
  # save the attached .config to linux build tree
  make.cross ARCH=mips 

All warnings (new ones prefixed by >>):

   fs/xfs/xfs_iomap.c: In function 'xfs_iomap_write_direct':
>> fs/xfs/xfs_iomap.c:242:2: warning: format '%ld' expects argument of type 'long int', but argument 5 has type 'size_t {aka unsigned int}' [-Wformat=]
     "err %d, off/cnt %lld/%ld, sector %ld, bytes %lld, im.stblk %lld, im.stoff %lld, im.blkcnt %lld",
     ^
>> fs/xfs/xfs_iomap.c:242:2: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'sector_t {aka long long unsigned int}' [-Wformat=]

vim +242 fs/xfs/xfs_iomap.c

   226		 */
   227		error = xfs_bmap_finish(&tp, &free_list, &committed);
   228		if (error)
   229			goto out_bmap_cancel;
   230	
   231		/* DAX needs to zero the entire allocated extent here */
   232		if (IS_DAX(VFS_I(ip)) && nimaps) {
   233			sector_t sector = xfs_imap_to_sector(VFS_I(ip), imap, offset);
   234	
   235			ASSERT(!ISUNWRITTEN(imap));
   236			ASSERT(nimaps == 1);
   237			error = dax_clear_blocks(VFS_I(ip),
   238					sector >> (VFS_I(ip)->i_blkbits - BBSHIFT),
   239					XFS_FSB_TO_B(mp, imap->br_blockcount));
   240			if (error) {
   241				xfs_warn(mp,
 > 242	 "err %d, off/cnt %lld/%ld, sector %ld, bytes %lld, im.stblk %lld, im.stoff %lld, im.blkcnt %lld",
   243					error, offset, count, 
   244					xfs_imap_to_sector(VFS_I(ip), imap, offset),
   245					XFS_FSB_TO_B(mp, imap->br_blockcount),
   246					imap->br_startblock, imap->br_startoff,
   247					imap->br_blockcount);
   248				goto out_trans_cancel;
   249			}
   250		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (39228 bytes)