linux-kernel - Re: [PATCH RESEND] rtsx_usb_ms: Use msleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1443438600.2517.33.camel@decadent.org.uk>
Date:	Mon, 28 Sep 2015 12:10:00 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Maxim Levitsky <maximlevitsky@...il.com>,
	Roger Tseng <rogerable@...ltek.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in
 polling loop

On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote:
> The subsystem is missing from the subject line.
> 
> On Mon, 28 Sep 2015, Ben Hutchings wrote:
> > rtsx_usb_ms creates a task that mostly sleeps, but tasks in
> > uninterruptible sleep still contribute to the load average (for
> > bug-compatibility with Unix).  A load average of ~1 on a system
> > that
> > should be idle is somewhat alarming.
> > 
> > Change the sleep to be interruptible, but still ignore signals.
> > 
> > A better fix might be to replace this loop with a delayed work
> > item.
> > 
> > References: https://bugs.debian.org/765717
> > Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> 
> How was this patch made?  Where's the diff etc?

With quilt.

> Why was this patch sent to me?

I think I must have added you previously as MFD maintainer, but as this
doesn't touch rtsx_pcr or rtsx_usb it's not really in your area.  Sorry
to bother you.

Ben.

> > ---
> > --- a/drivers/memstick/host/rtsx_usb_ms.c
> > +++ b/drivers/memstick/host/rtsx_usb_ms.c
> > @@ -706,7 +706,8 @@ poll_again:
> >  		if (host->eject)
> >  			break;
> >  
> > -		msleep(1000);
> > +		if (msleep_interruptible(1000))
> > +			flush_signals(current);
> >  	}
> >  
> >  	complete(&host->detect_ms_exit);
> 
-- 
Ben Hutchings
All extremists should be taken out and shot.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)