lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Sep 2015 05:33:53 -0700 From: "H. Peter Anvin" <hpa@...or.com> To: Denys Vlasenko <dvlasenk@...hat.com>, Ingo Molnar <mingo@...nel.org> CC: Andy Lutomirski <luto@...capital.net>, Borislav Petkov <bp@...en8.de>, Brian Gerst <brgerst@...il.com>, x86@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] x86/signal: Deinline get_sigframe, save 240 bytes This one makes me slightly nervous, because it isn't clear that these aren't potentially performance sensitive. On September 28, 2015 5:23:57 AM PDT, Denys Vlasenko <dvlasenk@...hat.com> wrote: >This function compiles to 277 bytes of machine code and has 4 >callsites. > >Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com> >CC: Ingo Molnar <mingo@...nel.org> >CC: Andy Lutomirski <luto@...capital.net> >CC: "H. Peter Anvin" <hpa@...or.com> >CC: Borislav Petkov <bp@...en8.de> >CC: Brian Gerst <brgerst@...il.com> >CC: x86@...nel.org >CC: linux-kernel@...r.kernel.org >--- > arch/x86/kernel/signal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c >index da52e6b..054a4d0 100644 >--- a/arch/x86/kernel/signal.c >+++ b/arch/x86/kernel/signal.c >@@ -196,7 +196,7 @@ static unsigned long align_sigframe(unsigned long >sp) > return sp; > } > >-static inline void __user * >+static void __user * >get_sigframe(struct k_sigaction *ka, struct pt_regs *regs, size_t >frame_size, > void __user **fpstate) > { -- Sent from my Android device with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists