linux-kernel - Re: [PATCH 1/2] selinux: ioctl_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXk95AvTKhd7r2Mh4H9rWK1CV2b+fog8GaHPYriD6JKBL+HvQ@mail.gmail.com>
Date:	Mon, 28 Sep 2015 08:22:22 -0700
From:	Jeffrey Vander Stoep <jeffv@...gle.com>
To:	Geliang Tang <geliangtang@....com>
Cc:	Paul Moore <paul@...l-moore.com>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	Eric Paris <eparis@...isplace.org>,
	James Morris <james.l.morris@...cle.com>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, SELinux <selinux@...ho.nsa.gov>
Subject: Re: [PATCH 1/2] selinux: ioctl_has_perm should be static

Acked-by: Jeff Vander Stoep <jeffv@...gle.com>

On Sun, Sep 27, 2015 at 8:10 AM, Geliang Tang <geliangtang@....com> wrote:
> Fixes the following sparse warning:
>
>  security/selinux/hooks.c:3242:5: warning: symbol 'ioctl_has_perm' was
>  not declared. Should it be static?
>
> Signed-off-by: Geliang Tang <geliangtang@....com>
> ---
>  security/selinux/hooks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 84d21f9..5265c74 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3239,7 +3239,7 @@ static void selinux_file_free_security(struct file *file)
>   * Check whether a task has the ioctl permission and cmd
>   * operation to an inode.
>   */
> -int ioctl_has_perm(const struct cred *cred, struct file *file,
> +static int ioctl_has_perm(const struct cred *cred, struct file *file,
>                 u32 requested, u16 cmd)
>  {
>         struct common_audit_data ad;
> --
> 2.5.0
>
>
> _______________________________________________
> Selinux mailing list
> Selinux@...ho.nsa.gov
> To unsubscribe, send email to Selinux-leave@...ho.nsa.gov.
> To get help, send an email containing "help" to Selinux-request@...ho.nsa.gov.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/