linux-kernel - RE: [PATCH 1/3] Thermal: initialize thermal zone device correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36DF59CE26D8EE47B0655C516E9CE64026F225EA@SHSMSX101.ccr.corp.intel.com>
Date:	Mon, 28 Sep 2015 17:30:30 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	Javi Merino <javi.merino@....com>
CC:	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"edubezval@...il.com" <edubezval@...il.com>,
	"Zhang, Rui" <rui.zhang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 1/3] Thermal: initialize thermal zone device correctly

Hi, Javi,

> -----Original Message-----
> From: Javi Merino [mailto:javi.merino@....com]
> Sent: Monday, September 28, 2015 10:28 PM
> To: Chen, Yu C
> Cc: linux-pm@...r.kernel.org; edubezval@...il.com; Zhang, Rui; linux-
> kernel@...r.kernel.org; stable@...r.kernel.org
> Subject: Re: [PATCH 1/3] Thermal: initialize thermal zone device correctly
> 
> On Sun, Sep 27, 2015 at 06:48:28AM +0100, Chen Yu wrote:
> > From: Zhang Rui <rui.zhang@...el.com>
> >
> > After thermal zone device registered, as we have not read any
> > temperature before, thus tz->temperature should not be 0, which
> > actually means 0C, and thermal trend is not available.
> > In this case, we need specially handling for the first
> > thermal_zone_device_update().
> >
> > Both thermal core framework and step_wise governor is enhanced to
> > handle this.
> 
> It may be worth pointing out that the step_wise governor is the only one
> that uses trends, so it's the only thermal governor that needs to be updated.
> 
OK, will add.
> 
> > -		if (old_target == instance->target)
> > +		if (instance->initialized &&
> > +		    old_target == instance->target)
> 
> nit: it fits in one line,
> 
> 		if (instance->initialized && old_target == instance->target)
> 
> is 77 characters.
> 
Not sure if the limit for one line is 75 in checkpatch.pl, I'll have a try.
Thanks!

Best Regards,
Yu