linux-kernel - RE: [PATCH 2/3] Thermal: handle thermal zone device properly during system sleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36DF59CE26D8EE47B0655C516E9CE64026F22613@SHSMSX101.ccr.corp.intel.com>
Date:	Mon, 28 Sep 2015 17:36:33 +0000
From:	"Chen, Yu C" <yu.c.chen@...el.com>
To:	Javi Merino <javi.merino@....com>
CC:	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"edubezval@...il.com" <edubezval@...il.com>,
	"Zhang, Rui" <rui.zhang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH 2/3] Thermal: handle thermal zone device properly during
 system sleep

Hi, Javi

> -----Original Message-----
> From: Javi Merino [mailto:javi.merino@....com]
> Sent: Monday, September 28, 2015 10:29 PM
> To: Chen, Yu C
> Cc: linux-pm@...r.kernel.org; edubezval@...il.com; Zhang, Rui; linux-
> kernel@...r.kernel.org; stable@...r.kernel.org
> Subject: Re: [PATCH 2/3] Thermal: handle thermal zone device properly
> during system sleep
> 
> On Sun, Sep 27, 2015 at 06:48:35AM +0100, Chen Yu wrote:
> > From: Zhang Rui <rui.zhang@...el.com>
> >
> >
> > +	register_pm_notifier(&thermal_pm_nb);
> 
> What if register_pm_notifier() fails?  It can't fail now, but that may in the
> future.  If we fail to register thermal when we can't register the genetlink
> family, maybe we should also fail to register thermal if we fail to register the
> pm notifier, don't you think?
> 
This pm notifier is mainly used for suspending situation, but it's not so 'critical' 
to terminate the initialization of thermal core if it failed, IMO. 
Hi, Rui, what do you think? Thx

Best Regards,
Yu