linux-kernel - [PATCH] staging: comedi: ni

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Sep 2015 21:54:45 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	linux-kernel@...r.kernel.org
Cc:	abbotti@....co.uk, hsweeten@...ionengravers.com,
	gregkh@...uxfoundation.org, surya.seetharaman9@...il.com,
	devel@...verdev.osuosl.org,
	Luis de Bethencourt <luisbg@....samsung.com>
Subject: [PATCH] staging: comedi: ni_tiocmd: remove unused code

Remove the unused code, which isn't implemented yet, using #if 0.

Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
---

Hi,

The code after the return is dead code. My understanding is that it is
there for when the output commands are implemented in the future.
Meanwhile it would be clearer if the code is removed with #if 0.

Thanks,
Luis

 drivers/staging/comedi/drivers/ni_tiocmd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c b/drivers/staging/comedi/drivers/ni_tiocmd.c
index 9b124b0..728c7f4 100644
--- a/drivers/staging/comedi/drivers/ni_tiocmd.c
+++ b/drivers/staging/comedi/drivers/ni_tiocmd.c
@@ -158,11 +158,13 @@ static int ni_tio_output_cmd(struct comedi_subdevice *s)
 		"output commands not yet implemented.\n");
 	return -ENOTSUPP;
 
+#if 0 /* unused */
 	counter->mite_chan->dir = COMEDI_OUTPUT;
 	mite_prep_dma(counter->mite_chan, 32, 32);
 	ni_tio_configure_dma(counter, true, false);
 	mite_dma_arm(counter->mite_chan);
 	return ni_tio_arm(counter, 1, NI_GPCT_ARM_IMMEDIATE);
+#endif
 }
 
 static int ni_tio_cmd_setup(struct comedi_subdevice *s)
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/