linux-kernel - Re: [GIT PULL rcu/urgent] Fix two more 4.3 regressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+icZUUYx1vgmvkpKCk9M3vHPFCuJ7JNbLEAYRojTRWm1NwpNg@mail.gmail.com>
Date:	Mon, 28 Sep 2015 08:24:53 +0200
From:	Sedat Dilek <sedat.dilek@...il.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL rcu/urgent] Fix two more 4.3 regressions

On Mon, Sep 28, 2015 at 8:03 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Sedat Dilek <sedat.dilek@...il.com> wrote:
>
>> [   23.874836] BUG: sleeping function called from invalid context at
>> kernel/workqueue.c:2678
>> [   23.874902] in_atomic(): 0, irqs_disabled(): 1, pid: 1411, name: acpid
>>
>> $ grep LOCKDEP /boot/config-4.3.0-rc2-438.1-llvmlinux-amd64
>
> Was this kernel built with LLVM?
>
> If yes then please do not report it as 'bugs' to lkml, unless you can also
> reproduce it under GCC. Please bring it up with the LLVM folks.
>

My apologies for flooding the ML.

Yes, this kernel was build with LLVM.

This snippet makes the BUG line go away for me.

--- a/drivers/hid/usbhid/hid-core.c
+++ b/drivers/hid/usbhid/hid-core.c
@@ -731,6 +731,7 @@ void usbhid_close(struct hid_device *hid)
         */
        spin_lock_irq(&usbhid->lock);
        if (!--hid->open) {
+               trace_hardirqs_off();
                spin_unlock_irq(&usbhid->lock);
                hid_cancel_delayed_stuff(usbhid);
                if (!(hid->quirks & HID_QUIRK_ALWAYS_POLL)) {
@@ -1392,6 +1393,8 @@ static void usbhid_disconnect(struct usb_interface *intf)

 static void hid_cancel_delayed_stuff(struct usbhid_device *usbhid)
 {
+       might_sleep();
+
        del_timer_sync(&usbhid->io_retry);
        cancel_work_sync(&usbhid->reset_work);
 }

What does this say to me?
HID problem?
CLANG problem?
Not sure, still digging into it.

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/