linux-kernel - Re: [PATCH] staging: comedi: cb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Sep 2015 10:55:09 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	amaury.denoyelle@...il.com, abbotti@....co.uk
Subject: Re: [PATCH] staging: comedi: cb_pcidas64: remove unused code

On 29/09/15 02:23, Greg KH wrote:
> On Mon, Sep 28, 2015 at 10:10:42PM +0100, Luis de Bethencourt wrote:
>> Remove the disabled code, for now, with #if 0.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@....samsung.com>
>> ---
>>
>> Hi,
>>
>> The code after the return is dead code. There is a comment saying it is
>> disabled for now, it would be good if the code is removed with #if 0 as
>> well.
> 
> The compiler doesn't add it anyway, so this is the same as what you just
> did, so I don't think it's needed.
> 
> thanks,
> 
> greg k-h
> 

Hi Greg,

I thought it would be easier to read if the code was explicitly marked as
dead/uncompiled.
You are correct though, it is probably not worth it.

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/