[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1443528119-31830-3-git-send-email-eu@felipetonello.com>
Date: Tue, 29 Sep 2015 13:01:57 +0100
From: "Felipe F. Tonello" <eu@...ipetonello.com>
To: linux-usb@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
Peter Chen <Peter.Chen@...escale.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Felipe Balbi <balbi@...com>,
Andrzej Pietrasiewicz <andrzej.p@...sung.com>,
"Felipe F. Tonello" <eu@...ipetonello.com>
Subject: [PATCH v3 2/4] usb: gadget: f_midi: free request when usb_ep_queue fails
This fix a memory leak that will occur in this case.
Signed-off-by: Felipe F. Tonello <eu@...ipetonello.com>
---
drivers/usb/gadget/function/f_midi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index 93212ca..163c0ce 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -546,9 +546,11 @@ static void f_midi_transmit(struct f_midi *midi, struct usb_request *req)
int err;
err = usb_ep_queue(ep, req, GFP_ATOMIC);
- if (err < 0)
+ if (err < 0) {
ERROR(midi, "%s queue req: %d\n",
midi->in_ep->name, err);
+ free_ep_req(ep, req);
+ }
} else {
free_ep_req(ep, req);
}
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists