linux-kernel - Re: [PATCH] regmap: Add HCI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150929145747.GQ30445@sirena.org.uk>
Date:	Tue, 29 Sep 2015 15:57:47 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Marcel Holtmann <marcel@...tmann.org>
Cc:	Loic Poulain <loic.poulain@...el.com>,
	linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: Add HCI support

On Fri, Sep 25, 2015 at 09:34:03PM +0200, Marcel Holtmann wrote:

Please fix your mail client to word wrap within paragraphs, it makes
your mails much easier to read.  I've reformatted your text for
legibility.

> > +/*
> > + * Register map access API - HCI support

> I do not think we can consider this generic HCI since at the moment I
> do not have enough information on what other manufactures are actually
> doing with their FM radio support. So lets call this regmap-ibt.c
> since we are actually using iBT as designation for Intel Bluetooth
> silicon.

If this is specific to a particular device it should just be kept within
the driver for that device.  If there are many devices implementing a
similar protocol then putting it in regmap to be shared makes sense.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)