linux-kernel - Re: [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1509291804510.4500@nanos>
Date:	Tue, 29 Sep 2015 18:06:59 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Oleksij Rempel <linux@...pel-privat.de>
cc:	linux-kernel@...r.kernel.org, marc.zyngier@....com,
	jason@...edaemon.net
Subject: Re: [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with
 different offsets

On Wed, 23 Sep 2015, Oleksij Rempel wrote:

Subject: irqchip/mxs: ..... Please

> +struct icoll_priv {
> +	void __iomem *vector;
> +	void __iomem *levelack;
> +	void __iomem *ctrl;
> +	void __iomem *stat;
> +	void __iomem *intr;
> +	/* number of interrupts per register */
> +	int intr_per_reg;

Why are you adding this here just to remove it in the next patch?

> +	void __iomem *clear;

Please do not add members which are not required for the preparatory
step.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/