linux-kernel - Re: [PATCH 2/2] tpm, tpm_tis: detect TPM2 FIFO devices based on HID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Sep 2015 01:43:57 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:	kbuild-all@...org, tpmdd-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, peterhuewe@....de,
	gregkh@...uxfoundation.org, jgunthorpe@...idianresearch.com,
	akpm@...ux-foundation.org, mjg59@...f.ucam.org,
	Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>,
	Marcel Selhorst <tpmdd@...horst.net>
Subject: Re: [PATCH 2/2] tpm, tpm_tis: detect TPM2 FIFO devices based on HID

Hi Jarkko,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

reproduce:
  # apt-get install sparse
  make ARCH=x86_64 allmodconfig
  make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/char/tpm/tpm_tis.c:136:13: sparse: cast to restricted __le32

vim +136 drivers/char/tpm/tpm_tis.c

   120	
   121	static inline int is_tpm2_fifo(struct acpi_device *dev)
   122	{
   123		struct acpi_table_tpm2 *tbl;
   124		acpi_status st;
   125	
   126		if (!has_hid(dev, "MSFT0101"))
   127			return 0;
   128	
   129		st = acpi_get_table(ACPI_SIG_TPM2, 1,
   130				    (struct acpi_table_header **) &tbl);
   131		if (ACPI_FAILURE(st)) {
   132			dev_err(&dev->dev, "failed to get TPM2 ACPI table\n");
   133			return 0;
   134		}
   135	
 > 136		if (le32_to_cpu(tbl->start_method) != TPM2_START_FIFO)
   137			return 0;
   138	
   139		return 1;
   140	}
   141	#else
   142	static inline int is_itpm(struct acpi_device *dev)
   143	{
   144		return 0;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/