linux-kernel - Re: Trivial clocksource driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1509292030010.4500@nanos>
Date:	Tue, 29 Sep 2015 20:32:19 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Mason <slash.tmp@...e.fr>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Daniel Lezcano <daniel.lezcano@...aro.org>
Subject: Re: Trivial clocksource driver

On Tue, 29 Sep 2015, Mason wrote:
> Hello everyone,
> 
> I am trying to submit a new ARM port, and Arnd pointed out that the
> clocksource code could not live in arch/arm/$PLATFORM, but had to
> move to drivers/clocksource (and it had to support DT).
> 
> Did I understand correctly? Is this the right place to submit code
> as provided below?


Yes, drivers/clocksource is the right place. You just need to submit a
formal patch, which includes a proper subject line, changelog, plus
the necessary Makefile and Kconfig modifications.
 
> #include <linux/delay.h>	/* register_current_timer_delay	*/

Please get rid of these silly tail comments. They provide absolutely
no value.

Other than that this looks reasonable.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/