lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150929195648.GG31505@google.com>
Date:	Tue, 29 Sep 2015 12:56:48 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Graham Moore <grmoore@...nsource.altera.com>
Cc:	linux-mtd@...ts.infradead.org,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org,
	Alan Tull <atull@...nsource.altera.com>,
	Dinh Nguyen <dinguyen@...nsource.altera.com>,
	Yves Vandervennet <yvanderv@...nsource.altera.com>,
	Enrico Jorns <ejo@...gutronix.de>
Subject: Re: [PATCH] mtd: nand: denali: max_banks calculation changed in
 revision 5.1

On Tue, Sep 29, 2015 at 11:31:21AM -0700, Brian Norris wrote:
> On Tue, Sep 29, 2015 at 10:01:10AM -0500, Graham Moore wrote:
> > On 07/21/2015 09:39 AM, Graham Moore wrote:
> > >diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> > >index 870c7fc..a98b41e 100644
> > >--- a/drivers/mtd/nand/denali.h
> > >+++ b/drivers/mtd/nand/denali.h
> > >@@ -178,6 +178,8 @@
> > >
> > >  #define REVISION				0x370
> > >  #define     REVISION__VALUE				0xffff
> > >+#define MAKE_COMPARABLE_REVISION(x)		swab16(x & REVISION__VALUE)
> 
> It's probably best to add parentheses around the 'x'.
> 
> > >+#define REVISION_5_1				0x00000501
> > >
> > >  #define ONFI_DEVICE_FEATURES			0x380
> > >  #define     ONFI_DEVICE_FEATURES__VALUE			0x003f
> > >
> > 
> 
> I can fix that up and apply, if no objections.

Pushed to l2-mtd.git with that fixup.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ