linux-kernel - Re: [PATCH v3 2/5] seccomp: add the concept of a seccomp filter FD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201510010231.ibjcmDLo%fengguang.wu@intel.com>
Date:	Thu, 1 Oct 2015 02:29:25 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Tycho Andersen <tycho.andersen@...onical.com>
Cc:	kbuild-all@...org, Kees Cook <keescook@...omium.org>,
	Alexei Starovoitov <ast@...nel.org>,
	Will Drewry <wad@...omium.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Andy Lutomirski <luto@...capital.net>,
	Pavel Emelyanov <xemul@...allels.com>,
	"Serge E. Hallyn" <serge.hallyn@...ntu.com>,
	Daniel Borkmann <daniel@...earbox.net>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	linux-api@...r.kernel.org,
	Tycho Andersen <tycho.andersen@...onical.com>
Subject: Re: [PATCH v3 2/5] seccomp: add the concept of a seccomp filter FD

Hi Tycho,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: i386-alldefconfig (attached as .config)
reproduce:
  git checkout 9613ae6bf5f111701614acb3eda3123d21a59239
  # save the attached .config to linux build tree
  make ARCH=i386 

All error/warnings (new ones prefixed by >>):

>> kernel/seccomp.c:998:10: error: expected ';', ',' or ')' before 'const'
             const char __user *filter)
             ^
   kernel/seccomp.c: In function 'do_seccomp':
>> kernel/seccomp.c:1016:10: error: implicit declaration of function 'seccomp_filter_fd' [-Werror=implicit-function-declaration]
      return seccomp_filter_fd(flags, uargs);
             ^
   cc1: some warnings being treated as errors

vim +998 kernel/seccomp.c

   992						   const char __user *filter)
   993	{
   994		return -EINVAL;
   995	}
   996	
   997	static inline long seccomp_filter_fd(unsigned int flags
 > 998					     const char __user *filter)
   999	{
  1000		return -EINVAL;
  1001	}
  1002	#endif
  1003	
  1004	/* Common entry point for both prctl and syscall. */
  1005	static long do_seccomp(unsigned int op, unsigned int flags,
  1006			       const char __user *uargs)
  1007	{
  1008		switch (op) {
  1009		case SECCOMP_SET_MODE_STRICT:
  1010			if (flags != 0 || uargs != NULL)
  1011				return -EINVAL;
  1012			return seccomp_set_mode_strict();
  1013		case SECCOMP_SET_MODE_FILTER:
  1014			return seccomp_set_mode_filter(flags, uargs);
  1015		case SECCOMP_FILTER_FD:
> 1016			return seccomp_filter_fd(flags, uargs);
  1017		default:
  1018			return -EINVAL;
  1019		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (9474 bytes)