linux-kernel - Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A323E65A-1631-4ADF-865D-04A5C38C6969@goldelico.com>
Date:	Wed, 30 Sep 2015 21:08:00 +0200
From:	"H. Nikolaus Schaller" <hns@...delico.com>
To:	Nathan Lynch <Nathan_Lynch@...tor.com>
Cc:	Ard Biesheuvel <ard.biesheuvel@...aro.org>,
	Szabolcs Nagy <szabolcs.nagy@....com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Will Deacon <will.deacon@....com>,
	Marek Belisko <marek@...delico.com>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: fix vdsomunge depends on glibc specific byteswap.h


Am 30.09.2015 um 20:17 schrieb Nathan Lynch <Nathan_Lynch@...tor.com>:

> On 09/30/2015 12:47 PM, H. Nikolaus Schaller wrote:
>> 
>> Am 30.09.2015 um 19:37 schrieb Nathan Lynch <Nathan_Lynch@...tor.com>:
>>> Why not just use a generic
>>> implementation like is found in mips' elf2ecoff?
>> 
>> Do you have a reference?
>> I can't find byte swapping in
>> 
>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/mips/boot/elf2ecoff.c?id=refs/tags/v4.3-rc3
> 
> See the swab16 and swab32 macros (yes, "swab" not "swap").
> 
> Or the __constant_swab* macros in include/linux/uapi/swab.h.
> 

Ah, I did search for swaP...

And, I though that they are more conditional on the CPU endianness but that
would be sort of htons() and ntohl() and friends.

Then I see no problem adding such macros and getting rid of the #include
completely. Which is compiler independent and OS independent.

Will prepare and submit a V2 asap.

Thanks and BR,
Nikolaus

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/