linux-kernel - Re: [RESEND PATCH v3 1/1] Add Corsair Vengeance K90 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1509302121020.30132@pobox.suse.cz>
Date:	Wed, 30 Sep 2015 21:33:36 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Clément Vuchener <clement.vuchener@...il.com>
cc:	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [RESEND PATCH v3 1/1] Add Corsair Vengeance K90 driver

On Wed, 30 Sep 2015, Clément Vuchener wrote:

> This patch implements a HID driver for the Corsair Vengeance K90 keyboard.
> 
> It fixes the behaviour of the keys using incorrect HID usage codes and 
> exposes the macro playback mode and current profile to the user space 
> through sysfs attributes. It also adds two LED class devices controlling 
> the "record" LED and the backlight.
> 
> Signed-off-by: Clément Vuchener <clement.vuchener@...il.com>
[ ... snip ... ]
> +struct k90_led {
> +	struct led_classdev cdev;
> +	int brightness;
> +	struct work_struct work;
> +	int removed;

This could be made bool.

Also the patch subject doesn't really follow the usual format we're using 
in hid.git.

Otherwise I like the code, thanks a lot for working on the driver. I have 
fixed the nits above and it's now queued in hid.git#for-4.4/corsair.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/