linux-kernel - Re: [PATCH 2/2] mm: fix declarations of nr, delta and nr_pagecache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150929222857.9f29351f.akpm@linux-foundation.org>
Date:	Tue, 29 Sep 2015 22:28:57 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alexandru Moise <00moses.alexander00@...il.com>
Cc:	mgorman@...e.de, vbabka@...e.cz, mhocko@...e.com, js1304@...il.com,
	hannes@...xchg.org, alexander.h.duyck@...hat.com,
	sasha.levin@...cle.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mm: fix declarations of nr, delta and
 nr_pagecache_reclaimable

On Wed, 30 Sep 2015 08:10:04 +0300 Alexandru Moise <00moses.alexander00@...il.com> wrote:

> > > --- a/mm/vmscan.c
> > > +++ b/mm/vmscan.c
> > > @@ -194,7 +194,7 @@ static bool sane_reclaim(struct scan_control *sc)
> > >  
> > >  static unsigned long zone_reclaimable_pages(struct zone *zone)
> > >  {
> > > -	int nr;
> > > +	unsigned long nr;
> > >  
> > >  	nr = zone_page_state(zone, NR_ACTIVE_FILE) +
> > >  	     zone_page_state(zone, NR_INACTIVE_FILE);
> > 
> > OK.
> > 
> 
> Are you sure? Mel Gorman raised the following issue on patch 1/2:
> 
> https://lkml.org/lkml/2015/9/29/253

__zone_watermark_ok() is very different from zone_reclaimable_pages().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/