linux-kernel - Re: [PATCH 1/7] phy: exynos-usb2: add vbus regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <560B7A6A.5010609@samsung.com>
Date:	Wed, 30 Sep 2015 08:00:10 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	Kishon Vijay Abraham I <kishon@...com>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org
Cc:	Robert Baldyga <r.baldyga@...sung.com>,
	John Youn <johnyoun@...opsys.com>,
	Kukjin Kim <kgene@...nel.org>,
	Kamil Debski <k.debski@...sung.com>
Subject: Re: [PATCH 1/7] phy: exynos-usb2: add vbus regulator support

Hello,

On 2015-08-27 11:54, Kishon Vijay Abraham I wrote:
> On Tuesday 25 August 2015 11:42 AM, Krzysztof Kozlowski wrote:
>> On 25.08.2015 14:47, Marek Szyprowski wrote:
>>> Hello,
>>>
>>> On 2015-08-21 14:44, Kishon Vijay Abraham I wrote:
>>>> On Friday 21 August 2015 06:08 PM, Marek Szyprowski wrote:
>>>>> Exynos USB2 PHY has separate power supply, which is usually provided by
>>>>> VBUS regulator. This patch adds support for it. VBUS regulator is
>>>>> optional, to keep compatibility with boards, which have VBUS provided
>>>>> from some always-on power source.
>>>>>
>>>>> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
>>>>> ---
>>>>>    .../devicetree/bindings/phy/samsung-phy.txt        |  3 +++
>>>>>    drivers/phy/phy-samsung-usb2.c                     | 25
>>>>> ++++++++++++++++++++--
>>>>>    drivers/phy/phy-samsung-usb2.h                     |  2 ++
>>>>>    3 files changed, 28 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt
>>>>> b/Documentation/devicetree/bindings/phy/samsung-phy.txt
>>>>> index 60c6f2a633e0..0289d3b07853 100644
>>>>> --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt
>>>>> +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt
>>>>> @@ -44,6 +44,9 @@ Required properties:
>>>>>        - the "ref" clock is used to get the rate of the clock provided
>>>>> to the
>>>>>          PHY module
>>>>>    +Optional properties:
>>>>> +- vbus-supply: power-supply phandle for vbus power source
>>>> how about using phy-supply?
>>> I wanted to make it a bit more descriptive (vbus-supply is rather self
>>> explaining name)
>>> and keep it in line with Exynos usb3-drd phy, which already supports
>>> vbus-supply.
>>> If you think that this is a bad idea, a will use phy-supply then.
>> This is actually supply for VBUS, not for the phy. Using phy-supply
>> would work fine and reduce the size of code... but would be rather a
>> hacky-use of phy and it could be misleading.
>>
>> I don't have strong feeling about this, both ideas have its advantages.
>> If I had to choose than I would like to use vbus-supply because of its
>> correctness with real-world (this is a VBUS after all).
> Alright.. lets use vbus-supply then.

Could you take this patch to -next then? I would like to have all needed 
pieces
merged to v4.4 to finally get USB gadget stuff working again on Trats2 
boards.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/