linux-kernel - Re: [PATCH v2] clk: add devm_of_clk_get() and devm_of_clk_get_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 30 Sep 2015 17:13:42 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Paul Osmialowski <newchief@...g.net.pl>
Cc:	kbuild-all@...org, Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
	Paul Osmialowski <pawelo@...g.net.pl>
Subject: Re: [PATCH v2] clk: add devm_of_clk_get() and
 devm_of_clk_get_by_name() functions

Hi Paul,

[auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore]

config: arm-sa1100 (attached as .config)
reproduce:
  wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
  chmod +x ~/bin/make.cross
  git checkout 4b38631724b90dc5a717a4467cbf9377e3bf9af2
  # save the attached .config to linux build tree
  make.cross ARCH=arm 

All error/warnings (new ones prefixed by >>):

>> drivers/clk/clk-devres.c:39:13: error: redefinition of 'devm_of_clk_get'
    struct clk *devm_of_clk_get(struct device *dev, struct device_node *np,
                ^
   In file included from drivers/clk/clk-devres.c:7:0:
   include/linux/clk.h:539:27: note: previous definition of 'devm_of_clk_get' was here
    static inline struct clk *devm_of_clk_get(struct device *dev,
                              ^
>> drivers/clk/clk-devres.c:60:13: error: redefinition of 'devm_of_clk_get_by_name'
    struct clk *devm_of_clk_get_by_name(struct device *dev, struct device_node *np,
                ^
   In file included from drivers/clk/clk-devres.c:7:0:
   include/linux/clk.h:545:27: note: previous definition of 'devm_of_clk_get_by_name' was here
    static inline struct clk *devm_of_clk_get_by_name(struct device *dev,
                              ^

vim +/devm_of_clk_get +39 drivers/clk/clk-devres.c

    33		return clk;
    34	}
    35	EXPORT_SYMBOL(devm_clk_get);
    36	
    37	#ifdef CONFIG_OF
    38	
  > 39	struct clk *devm_of_clk_get(struct device *dev, struct device_node *np,
    40				    int index)
    41	{
    42		struct clk **ptr, *clk;
    43	
    44		ptr = devres_alloc(devm_clk_release, sizeof(*ptr), GFP_KERNEL);
    45		if (!ptr)
    46			return ERR_PTR(-ENOMEM);
    47	
    48		clk = of_clk_get(np, index);
    49		if (!IS_ERR(clk)) {
    50			*ptr = clk;
    51			devres_add(dev, ptr);
    52		} else {
    53			devres_free(ptr);
    54		}
    55	
    56		return clk;
    57	}
    58	EXPORT_SYMBOL(devm_of_clk_get);
    59	
  > 60	struct clk *devm_of_clk_get_by_name(struct device *dev, struct device_node *np,
    61					    const char *name)
    62	{
    63		struct clk **ptr, *clk;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (21715 bytes)