linux-kernel - Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150930132919.GI10997@leverpostej>
Date:	Wed, 30 Sep 2015 14:29:19 +0100
From:	Mark Rutland <mark.rutland@....com>
To:	"Ivan T. Ivanov" <ivan.ivanov@...aro.org>
Cc:	Andy Gross <agross@...eaurora.org>,
	David Brown <davidb@...eaurora.org>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jslaby@...e.com>,
	Frank Rowand <frank.rowand@...ymobile.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <Pawel.Moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-soc@...r.kernel.org" <linux-soc@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH v2 4/6] tty: serial: msm: Add TX DMA support

On Wed, Sep 30, 2015 at 01:08:24PM +0100, Ivan T. Ivanov wrote:
> Add transmit DMA support for UARTDM type of controllers.
> 
> Tested on APQ8064, which have UARTDM v1.3 and ADM DMA engine
> and APQ8016, which have UARTDM v1.4 and BAM DMA engine.
> 
> Signed-off-by: Ivan T. Ivanov <ivan.ivanov@...aro.org>
> ---
>  .../devicetree/bindings/serial/qcom,msm-uartdm.txt |   3 +
>  drivers/tty/serial/msm_serial.c                    | 312 +++++++++++++++++++--
>  drivers/tty/serial/msm_serial.h                    |   3 +
>  3 files changed, 294 insertions(+), 24 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> index a2114c217376..a600023d9ec1 100644
> --- a/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> +++ b/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt
> @@ -26,6 +26,9 @@ Required properties:
>  Optional properties:
>  - dmas: Should contain dma specifiers for transmit and receive channels
>  - dma-names: Should contain "tx" for transmit and "rx" for receive channels
> +- qcom,tx-crci: Identificator <u32> for Client Rate Control Interface to be
> +           used with TX DMA channel. Required when using DMA for transmission
> +           with UARTDM v1.3 and bellow.

This sounds like it belongs in the dma-specifier, and dealt with by the
DMA controller driver.

Why does the UART driver need to know about this?

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/